-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fdc3) - Fixing flaky DesktopAgent tests #537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilla28
force-pushed
the
skip/da-channel-test
branch
from
March 7, 2024 08:54
3fdc0e3
to
132f7bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 45 45
Lines 2359 2359
Branches 299 239 -60
=======================================
Hits 2126 2126
- Misses 229 232 +3
+ Partials 4 1 -3 |
bingenito
previously approved these changes
Mar 8, 2024
lilla28
force-pushed
the
skip/da-channel-test
branch
3 times, most recently
from
March 14, 2024 09:47
b3f04f8
to
5131633
Compare
lilla28
changed the title
fix(fdc3) - Skippng StoreIntent_succeeds_with_channel test as it's flaky
fix(fdc3) - Fixing flaky DesktopAgent tests
Mar 14, 2024
ztanczos
approved these changes
Mar 14, 2024
lilla28
force-pushed
the
skip/da-channel-test
branch
from
March 14, 2024 13:14
5131633
to
ebe9b52
Compare
kruplm
approved these changes
Mar 14, 2024
lilla28
force-pushed
the
skip/da-channel-test
branch
4 times, most recently
from
March 18, 2024 13:54
ec0b52b
to
f263521
Compare
ZKRobi
approved these changes
Mar 19, 2024
…sts to finish before raising the intent
lilla28
force-pushed
the
skip/da-channel-test
branch
from
March 19, 2024 09:38
f263521
to
f4f0d6e
Compare
ZKRobi
pushed a commit
to ZKRobi/ComposeUI
that referenced
this pull request
Mar 22, 2024
…sts to finish before raising the intent (morganstanley#537)
kruplm
pushed a commit
that referenced
this pull request
Apr 10, 2024
…sts to finish before raising the intent (#537)
lilla28
added a commit
to lilla28/ComposeUI
that referenced
this pull request
Jul 12, 2024
…sts to finish before raising the intent (morganstanley#537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: